Layer/Tag Users #33
Draft
Layer/Tag Users #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display layer names instead of numbers; UI polish; Code cleanup
… prefab; Cleanup and optimization
…ts or containers; Clean up Prefab Tag/Layer Users windows
Misc cleanup; Update .plan file
Misc cleanup; Update .plan
…if showing a filter with no results
# Conflicts: # Editor/Unity.Labs.SuperScience.Editor.api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add utilities for auditing project/scene usage of layers and tags
Testing status
Tested during release prep
Technical risk
Low -- Adds a handful of self-contained windows
Comments to reviewers
As always, a quick side-bar turned into a weekend's worth of work! 😅
I'm pretty happy with where I've gotten these utility windows functionality-wise, but there is a ton of duplicated code which I'd like to take a crack at unifying. The
MissingReferenceswindowutilities are a good start at this, but I'd like to create a newAnalysisWindowbase class and supportingFolder,GameObjectContainer,ComponentContainer, etc. base classes which all of these utilities (along withSolidColorTextures) can share. The current design also violates MVC in places but I think this gets much closer to MVC with theCreateIfNeccessarymethods cleanly breaking out the analysis/generation portion from the UI. I just need to move these methods out of their respective classes.The
.planfile lays out most of what I want to do before I take this one out of draft. I'd like to land #31 ahead of that as well so I can include it in the refactor. Still, I thought it would be nice to share my current progress in case anyone finds it useful. Some screenshots of the current state: